Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run markdownlint when changing the linter #600

Merged
merged 1 commit into from
Dec 1, 2023
Merged

run markdownlint when changing the linter #600

merged 1 commit into from
Dec 1, 2023

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Dec 1, 2023

When bumping markdownlint I noticed the linter change isn't actually tested in Prow as no .md files were changed.

Run markdownlint when touching the linter script, so the rule ignores as well as component bumps get tested.

@tuminoid
run markdownlint when changing the linter
7f4763f 
When bumping markdownlint I noticed the linter change isn't actually
tested in Prow as no .md files were changed.

Run markdownlint when touching the linter script, so the rule ignores
as well as component bumps get tested.
@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 1, 2023
@tuminoid
Copy link
Member Author

tuminoid commented Dec 1, 2023

/override test-ubuntu-integration-main
Not tested by integration.

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: test-ubuntu-integration-main

In response to this:

/override test-ubuntu-integration-main
Not tested by integration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

smoshiur1237
smoshiur1237 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2023
@tuminoid
Copy link
Member Author

tuminoid commented Dec 1, 2023

/assign @lentzi90

This was referenced Dec 1, 2023
Merged
Merged
Sunnatillo
Sunnatillo reviewed Dec 1, 2023
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kashifest
kashifest reviewed Dec 1, 2023
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why aren't we bumping the markdown container images also here?

@smoshiur1237 smoshiur1237 mentioned this pull request Dec 1, 2023
Merged
@tuminoid
Copy link
Member Author

tuminoid commented Dec 1, 2023

why aren't we bumping the markdown container images also here?

They are not all merged yet, and since this is not merged, they're not really tested.

@kashifest
Copy link
Member

They are not all merged yet, and since this is not merged, they're not really tested.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2023
@metal3-io-bot metal3-io-bot merged commit 5454685 into metal3-io:main Dec 1, 2023
1 check passed
@metal3-io-bot
Copy link
Collaborator

@tuminoid: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

When bumping markdownlint I noticed the linter change isn't actually tested in Prow as no .md files were changed.

Run markdownlint when touching the linter script, so the rule ignores as well as component bumps get tested.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid tuminoid deleted the tuomo/run-markdownlint-when-bumping-linter branch December 1, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunnatillo Sunnatillo Sunnatillo left review comments

@kashifest kashifest kashifest left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 approved these changes

Assignees

@lentzi90 lentzi90

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tuminoid @metal3-io-bot @kashifest @Sunnatillo @smoshiur1237 @lentzi90